"Accepting" code changes can silently fail

Tagged:
Project:GNU Smalltalk
Component:VisualGST
Category:bug
Priority:normal
Assigned:MrGwen
Status:committed
Description

Use the GtkBrowser to load a selector, make a change...

1.) reference a variable that does not accept..
2.) Right click and press Accept in the context menu

   (the code will not be saved)

3.) Click on another selector, a dialog will popup asking to accept or discard the change, press accept..

the code change is gone without being saved, the error (modal?) should be shown to the user and the user should be able to correct it.

Updates

#1 submitted by Gwenael Casaccio on Mon, 06/21/2010 - 08:21
Assigned to:Unassigned» MrGwen
#2 submitted by Paolo Bonzini on Wed, 06/23/2010 - 08:39

won't be fixed for 3.2.1. the new save widget however makes "Accept" much less intrusive, so you can "Ctrl-S" as much as you want.

#3 submitted by Paolo Bonzini on Sat, 10/16/2010 - 11:31
Status:active» committed

fix committed to my repo, breaks non-browser tools

User login