Home » Projects » GNU Smalltalk » Issues

CPU usage is high when there is an exception

By Gwenael Casaccio - Posted on November 3rd, 2009
Project:GNU Smalltalk
Component:VisualGST
Category:bug
Priority:critical
Assigned:Unassigned
Status:active
Description

When there is an exception in VisualGST gst uses 100% of the CPU.

To reproduce it this is simple in a workspace : self halt

Updates

#1 submitted by Paolo Bonzini on Wed, 11/18/2009 - 11:02

This would fix it:

diff --git a/packages/gtk/GtkImpl.st b/packages/gtk/GtkImpl.st
index 6a2d2fc..6097775 100644
--- a/packages/gtk/GtkImpl.st
+++ b/packages/gtk/GtkImpl.st
@@ -502,7 +502,7 @@ Gtk class extend [
         GTK.Gtk main: sem.
         sem wait.
         
-        [GTK.Gtk mainIterationDo: false.
+        [GTK.Gtk mainIterationDo: true.
         GTK.Gtk shouldQuit] 
                 whileFalse: [Processor yield]
     ]

but I have to check the impact on simulation speed (e.g. does moving the mouse increase the speed of simulation? that would be bad!). To fix it properly, the glib event loop should be hacked up to run the event loop together with Smalltalk code:

  1. Place the main loop at high priority and make it do something like this: 1) use g_main_context_set_poll_func and in the poll function set up SIGIO notification for the file descriptors, call g_main_context_pending to get this poll function called; 2) wait on a semaphore to be triggered by the SIGIO notifications; 3) revert to the default poll function and call g_main_context_iteration in non-blocking mode.
  2. Besides this, in sysdep/win32/events.c use MsgWaitForSingleObjects instead of WaitForSingleObject

User login