inefficient copying of dictionaries

Project:GNU Smalltalk
Component:Base classes
Category:bug
Priority:minor
Assigned:Unassigned
Status:fixed
Description

While copying it is useless to compare added keys to existing ones, because keys are guaranteed to be unique. GNU Smalltalk should simply look for an empty slot in #addWhileGrowing: and #whileGrowingAt:put:.

Updates

#1 submitted by Paolo Bonzini on Tue, 01/22/2008 - 17:00

committed to master as 6ccb43a. It unveiled a latent problem in CompiledCode>>#hash (which could possibly trigger infinite loops), and that was committed to both stable-3.0 (a591dc6) and master (43311f1).

#2 submitted by Paolo Bonzini on Tue, 01/22/2008 - 17:01
Status:active» fixed

User login